Py312 compat #147
Open
Py312 compat #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only regexes that include escapes and such cause errors, but use r"" everywhere for consistency. Closes: eLvErDe#146 Signed-off-by: Hank Leininger <hlein@korelogic.com>
…ping If we want the \[ ... \] escaping to propagate to os.popen, escape the escape. Signed-off-by: Hank Leininger <hlein@korelogic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that these are only minimally tested because the only relevant hardware I have access to are megaraid-sas, and some code paths only get exercised when an array is degraded and mine are not. But it compiles, so, ship it...