[megaclisas-status] support out of order VDs #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't assume that the virtual disk IDs are contiguous starting with ID 0. For example, it is possible to have two VDs with IDs 1 and 3.
Author
|
Hi, Two of our servers were upgraded, and their VD IDs are no longer contiguous. Here's a patch that might propertly address this problem. It seems to work fine here, but I'm assuming that the "Target Id" field is the correct ID value and not the "Virtual Drive" field, as can be seen from the output of: megacli -LDInfo -LALL -a0 -NoLog | grep "^Virtual Drive: " In our case, both numbers are exactly the same. I found another user who created a delta to solve this same problem, at https://github.com/npinto/megaclisas-status. |
eLvErDe
changed the title
Contributor
|
Could you please test with the latest version of megaclisas-status? I believe I had fixed that in my tree.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't assume that the virtual disk IDs are contiguous starting with ID
0. For example, it is possible to have two VDs with IDs 1 and 3.