feat(special): add Special:WantedPages report page#1953
Conversation
|
Verdict: Needs visual approval PR #1953: feat(special): add Special:WantedPages report page Engineering:
Changed files:
Guardrails:
Decision surface:
What to check:
Preview links:
Cross-repo validation:
Synced 679 published articles from taopedia-articles Human decision:
Automated review by Taopedia Site Maintainer. |
|
Follow-up for the maintainer-bot's cross-repo build OOM report:
I have not changed the product surface or the external evidence. |
|
/merge |
There was a problem hiding this comment.
Verdict: Needs visual approval
PR #1953: feat(special): add Special:WantedPages report page
Engineering:
- Review type: Visual/product review
- CI: All required CI checks passed: build
- Cross-repo build: pass
- Risk: high
- Changed files: 7
- Changed lines: 159
Changed files:
scripts/check-sitemap.jsscripts/check-wanted-pages.jssrc/lib/share-preview.tssrc/lib/wanted-pages-context.tssrc/pages/sitemap.xml.tssrc/pages/wiki/special/wantedpages.astrosrc/pages/wiki/special/wantedpages.json.ts
Guardrails:
- Operational/build/deploy files changed; maintainer review required.
- Visual layout/style/rendering files changed; visual approval required.
Decision surface:
- Checks and cross-repo build passed; this is waiting on visual approval only.
- If the after screenshots look correct, comment
/merge. - If they look wrong or the change should not ship, comment
/close.
What to check:
- Special page
/wiki/special/wantedpages/: page title, table/list content, navigation links, and empty/error states. - Changed page route(s):
src/pages/sitemap.xml.ts.
Preview links:
- Production reference: https://taopedia.org
- No automatic Netlify preview is available. Comment
/previewto create on-demand before/after draft deploys for this PR.
Cross-repo validation:
- pass merged checkout: PR head dde5c3a merges cleanly into test. Build/render is validated by the required GitHub Actions
buildcheck.
Human decision:
- Review only the visual evidence shown above for product fit.
- Comment
/mergeto merge if this should ship. - Comment
/closeto close if this should not ship.
Maintainer command /merge accepted.
Automated review by Taopedia Site Maintainer.
Summary
Special:WantedPagespage at/wiki/special/wantedpages/wantedpages.jsonstay in lockstepChange Type
Real Behavior Proof
https://taopedia.org/wiki/special/wantedpages/returns HTTP 404, whilehttps://taopedia.org/wiki/special/wantedpages.jsonalready exists.Wanted pagesreport at the canonicalSpecial:route.0wanted pages, so the route renders the correct empty state instead of a 404.Before (
https://taopedia.org/wiki/special/wantedpages/, 1440px viewport)After (built route at
/wiki/special/wantedpages/, 1440px viewport)Validation
npm run buildnode scripts/check-content-sanitizer.jsnode scripts/check-frontmatter.jsnode scripts/check-history-parser.jsnode scripts/check-warm-function.jsChecklist
Special:WantedPagespage