Skip to content

Keep the ingest path through the layout-first Continue handoff [#1131]#1358

Open
dripsmvcp wants to merge 1 commit into
e35dev:mainfrom
dripsmvcp:contrib/layout-first-continue-ingest-path
Open

Keep the ingest path through the layout-first Continue handoff [#1131]#1358
dripsmvcp wants to merge 1 commit into
e35dev:mainfrom
dripsmvcp:contrib/layout-first-continue-ingest-path

Conversation

@dripsmvcp

Copy link
Copy Markdown
Contributor

Summary

  • Keeps the creator on the ingest shell path when they Continue out of the layout-first placement detour: the ingest path's "Place videos in layout" link opens layout-first.html?path=ingest&from=ingest, and the back link already returns to the ingest path, but Continue hardcoded path=episode and silently switched them onto the episode path.
  • Guards the carry in the preview app: app-route-context.js only kept the layout/slots handoff params for path=episode, so an ingest-path role mapping would have dropped the placed layout and fallen back to generic names.
  • Unknown or absent path values keep the default episode path unchanged.

Verification

  • git diff --check
  • node preview/layout-first-continue-ingest-path.test.js
  • Full dependency-free suite: all preview/.test.js and prototype/.test.js pass
  • Local review bot passed

…handoff

The ingest path's "Place videos in layout" detour opens layout-first with
path=ingest, and the back link already returns there — but Continue
hardcoded path=episode, silently switching the creator onto the episode
path. Continue now keeps the incoming ingest path, and the preview app
route context keeps the layout/slots handoff alive on that ingest route
so role mapping still sees the placed videos.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant