fix(canvas): locked layers cannot be reordered or displaced#1357
Open
Tet-9 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1248
What
Locked layers could still be moved via the ▲/▼ buttons, and unlocked layers could displace a locked neighbor by moving into its slot — exactly the "moved by accident" scenario the lock is meant to prevent.
Fix
Extracted a pure
reorderLayers(list, index, delta)function that refuses the move when either the moved layer or the destination neighbor is locked.move()now delegates to it.The ▲/▼ buttons are disabled when the layer is locked or when the adjacent neighbor in that direction is locked, so the UI reflects the constraint before the user tries to act.
Unlocked layers that have no locked neighbors are unaffected.
Testing
npm testpasses (104 smoke tests)backgroundlayer (index 4 in the sample) cannot be moved up, and the unlockedbrandlayer above it cannot be moved down into its slot