Guard episode-runtime-shaping fix-routing with a regression test [#961]#1356
Open
minion1227 wants to merge 1 commit into
Open
Guard episode-runtime-shaping fix-routing with a regression test [#961]#1356minion1227 wants to merge 1 commit into
minion1227 wants to merge 1 commit into
Conversation
…dev#961] episode-runtime-shaping already hands every tightening opportunity off to the screen that owns that edit (long pauses -> pause & cross-talk cleanup, an over-long segment -> show segment system, a long intro -> intro & outro builder, a repeated point -> transcript search) instead of cutting in place, and the target stays advisory so it never blocks export. None of that was guarded by a test. Add a focused regression test that asserts each opportunity renders an "Open <owner> →" link to a real fix screen, that the four documented routes stay wired to their owning screens, and that runtime shaping never gates export. Test-only change; no production code is modified. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #961.
What & why
prototype/episode-runtime-shaping.htmlalready does the right thing: it treatsthe runtime target as guidance, not a hard cap, and every tightening
opportunity it surfaces hands the edit off to the screen that owns that edit
rather than trying to make the cut in place. But none of that routing was
guarded by a test, so a future change could silently drop a hand-off link,
point an opportunity at the wrong screen, or turn the advisory target into an
export blocker — with nothing to catch it.
This adds a focused regression test for that behaviour. It is a test-only
change; no production code is modified.
What the test guards
prototype/episode-runtime-shaping-fix-routing.test.jsasserts:renders a
fix-linkwhosehrefis the opportunity'sroute, labelledOpen <owner> →.routein theOPPORTUNITIESdata resolves to areal prototype screen on disk.
pause-crosstalk-cleanup.htmlshow-segment-system.htmlintro-outro-builder.htmltranscript-search-navigation.htmlexport at any length and the target does not block export.
Verification
The verification commands pass: