Place several recordings at once on the preview canvas [#1131]#1344
Open
codevector96 wants to merge 1 commit into
Open
Place several recordings at once on the preview canvas [#1131]#1344codevector96 wants to merge 1 commit into
codevector96 wants to merge 1 commit into
Conversation
The preview/layout canvas accepts one uploaded video per slot (e35dev#1266), but a creator with synced Riverside-style tracks had to add them one slot at a time — unlike the layout-first start, which lets you drop them all at once. Bring that multi-file placement to the preview canvas so the two surfaces match. Add placeVideoFiles(): it fills the slot the drop/pick lands on, then spills the remaining videos into the next empty visible slots in order (required speaker slots first, optional b-roll last). The batch is de-duplicated by recording identity (one source can't fill two speaker slots), the surplus is reported when there are more videos than open slots, and a non-video file in the batch is skipped with a creator-facing note — matching the layout-first behavior (e35dev#1189/e35dev#1197/e35dev#1205/e35dev#1209). The slot file inputs gain `multiple`, and the drop and file-input handlers route through the new path. Single-file drops/picks are unchanged. Verification: extends preview/layout-first-canvas-handoff.test.js to drop multiple files (spill), a batch with a non-video (skip + report), an overflowing batch (surplus reported), and a duplicate batch (placed once); updates the two input-markup assertions for the new `multiple` attribute. `npm test` passes (104 files).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The preview/layout canvas accepts one uploaded video per slot (#1266), but a creator with synced Riverside-style tracks had to add them one slot at a time — unlike the layout-first start, which lets you drop them all at once. This brings multi-file placement to the preview canvas so the two surfaces match (#1131).
What it adds
placeVideoFiles(): fills the slot the drop/pick lands on, then spills the remaining videos into the next empty visible slots in order (required speaker slots first, optional b-roll last). It:matching the layout-first behavior (#1189/#1197/#1205/#1209). The slot file inputs gain
multiple, and the drop + file-input handlers route through the new path. Single-file drops/picks are unchanged.Verification
Extends
preview/layout-first-canvas-handoff.test.jsto cover spill, non-video skip, overflow, and duplicate batches; updates two input-markup assertions for the newmultipleattribute.npm testpasses (104 files).