Make social links drive speaker names in preview#65
Closed
grnlemon wants to merge 2 commits into
Closed
Conversation
Wire the setup social-link fields through to the live composed preview: derived handles now update canvas speaker labels immediately, persist across Split/Stack/Spotlight, clear/replace per bucket only, and keep export enabled. - episode.js: broaden deriveHandle (plain handles, trailing slashes, youtube @Handles) and add speakerLabels() for preview/export consumers - preview.js: paint scaled labels per layout rect and expose data-speaker-labels on the canvas for verification - ui.js: handle both input and change on social-link fields; force a drawFrame after link edits so preview labels refresh without waiting - verify-social-context.mjs: upload 3 speakers, assert canvas + setup derived names, preset survival, per-speaker clear/replace, export enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
input/change, and persist across Split/Stack/Spotlight.deriveHandle()for plain handles, trailing slashes, and YouTube@handleURLs.Closes #63
Test plan
node scripts/lint.mjsnode scripts/typecheck.mjsnode scripts/run-tests.mjs(19 tests)node scripts/preview-build.mjsnode scripts/verify-social-context.mjs— 3 speakers, canvasdata-speaker-labels, setup hints, preset survival, clear/replace per bucket, export enablednode scripts/verify-rendered-preview.mjsnode scripts/verify-export.mjs