Skip to content

refactor: farmer content standalone#569

Draft
chrismclarke wants to merge 1 commit intomainfrom
refactor/farmer-content-standalone
Draft

refactor: farmer content standalone#569
chrismclarke wants to merge 1 commit intomainfrom
refactor/farmer-content-standalone

Conversation

@chrismclarke
Copy link
Copy Markdown
Collaborator

@chrismclarke chrismclarke commented Mar 28, 2026

TODO

  • Migrate video player to standalone
  • Update farmer content tsconfig for strictStandalone
  • Update all other farmer-content deps to be standalone (as required)
  • Test build and functional testing
  • Consider cdr opt-out (verify if onPush used throughout)

Description

Summary of main changes

Discussion

Feedback discussion points if relevant (should also tag as Feedback Discussion)

Preview

Link to app preview if relevant

Screenshots / Videos

Include at least 1-2 screenshots of videos if visual changes

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request converts the PicsaFarmerContent component to a standalone architecture and updates the routing configuration to use lazy loading for tool-related components. A critical issue was identified in FarmerToolPlaceholderComponent where the standalone: true property is missing; this is required for components that utilize the imports property to avoid compilation errors.


@Component({
selector: 'farmer-content-tool',
imports: [RouterModule],
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This component appears to be intended as a standalone component, but it's missing the standalone: true property in the @Component decorator. Without this, the component will not be treated as standalone, and using the imports array will result in a compilation error.

  standalone: true,
  imports: [RouterModule],

@nx-cloud
Copy link
Copy Markdown

nx-cloud bot commented Mar 28, 2026

View your CI Pipeline Execution ↗ for commit 478db7e

Command Status Duration Result
nx build ✅ Succeeded 27s View ↗
nx run-many --target=lint ✅ Succeeded 3s View ↗

☁️ Nx Cloud last updated this comment at 2026-03-28 02:09:57 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

App: Farmer Updates related to Farmer app maintenance

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

1 participant