Docs/geojson data

[chrismclarke]

Description

Summary of main changes

Screenshots / Videos

Include at least 1-2 screenshots of videos if visual changes

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines and reorganizes the deployment documentation, providing clearer guidance on how to add new countries and manage geographical data within the application. It distinguishes between manual/legacy geo data processes and a new, dashboard-managed approach, ensuring that users have up-to-date and structured instructions for these critical deployment steps.

Highlights

• Documentation Restructuring: Renamed and reorganized documentation files related to deployment, specifically for adding new countries and managing geographical data.
• Country Addition Process Clarified: Updated the 'Add Country' documentation with more detailed SQL commands for database updates, including INSERT statements for geo.countries and geo.locales, and ALTER TABLE for public.translations.
• Geo Data Management Documentation: Introduced new documentation for a dashboard-managed geo data process, while moving the manual/legacy map tile documentation to a separate file.
• Navigation Updates: Modified the _meta.ts file to reflect the new file names and titles in the documentation navigation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• app/deployment/01-new-country/page.mdx
  • Renamed from new-deployment/page.mdx.
  • Updated country code addition from ALTER TYPE to INSERT INTO geo.countries.
  • Updated language code addition from ALTER TYPE to INSERT INTO geo.locales.
  • Added SQL commands to ALTER table public.translations for new locale columns.
  • Included a TODO section for review and tidying.
• app/deployment/02-map-geo-data--legacy/page.mdx
  • Renamed from map-tiles/page.mdx.
  • Updated the main heading to 'Map Geo Data (Manual/Legacy)'.
  • Removed 'Future TODOs' and 'Legacy Docs' sections.
• app/deployment/02-map-geo-data/page.mdx
  • Added new documentation explaining the dashboard-managed map geo data process.
  • Included a link to the geo-boundaries-topojson repository.
• app/deployment/_meta.ts
  • Updated navigation entries to reflect the new file names and titles for 'Add New Country' and 'Map Geo Data'.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the documentation for adding a new country and managing geo-data. The changes are mostly good, but I've found a few issues. The SQL snippet for altering the translations table contains invalid syntax for column names with hyphens, which will cause errors for anyone following the guide. I've provided a correction. Additionally, there are a couple of 'TODO' notes in the documentation that should be removed to ensure the documentation is clean and complete. Please see my detailed comments.

[gemini-code-assist]

The SQL statements for adding columns to public.translations are invalid. Column names containing hyphens, like en-ZW, must be enclosed in double quotes in PostgreSQL to be valid identifiers. Without quoting, these ALTER TABLE commands will fail.

ALTER table public.translations ADD "en-ZW" text;
ALTER table public.translations ADD "sn-ZW" text;
ALTER table public.translations ADD "nd-ZW" text;

[gemini-code-assist]

This 'TODO' heading appears to be a development note and should be removed from the final documentation to keep it clean and professional.

[gemini-code-assist]

This 'TODO' placeholder should be removed or replaced with actual examples before merging. Leaving such notes in the final documentation can be confusing for users.