refactor: unify oxfmt invocation behind a shared runOxfmt helper - #2569
Merged
Conversation
Extract the runOxfmt helper from generate-docs-content.ts into scripts/run-oxfmt.ts and use it from generate-supported-tools-tables.ts and generate-json-schema.ts. All three call sites now share one runner (npx) and the Windows shell handling, so a future fix cannot silently miss one of them.
Address review feedback: pass --no-install so npx cannot silently fetch an oxfmt version other than the pinned devDependency, export repoRoot so generate-docs-content.ts reuses the single definition, and add unit tests covering the empty-path guard, relative path handling, and the Windows-only shell branch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unify the three oxfmt invocations in
scripts/behind a single shared helper.scripts/run-oxfmt.tsexportingrunOxfmt(paths: string[]), standardized onnpxwithshell: process.platform === "win32"and repo-root-relative paths.scripts/generate-docs-content.tsnow imports the helper instead of defining its own copy.scripts/generate-supported-tools-tables.tsno longer uses its ownpnpm exec oxfmtcall, which was missing the Windows shell handling.scripts/generate-json-schema.tsno longer uses its ownnpx oxfmtcall, which was also missing the Windows shell handling.No functional change to generated output:
pnpm run generate:tables,pnpm run generate:docs-content, andpnpm run generate:schemaall leavegit diffempty.Test plan
pnpm cicheck(full: code + content, including the docs-content and supported-tools drift gates) passes.Closes #2559
🤖 Generated with Claude Code