Feature / update comment error message

[sbrody]

Changes markup for comment error messages in line with update to 4.0. Can be tested once this PR has been approved.

[RobjS]

@sbrody Do you know how I can trigger this markup to appear in the frontend?

[sbrody]

@sbrody Do you know how I can trigger this markup to appear in the frontend?

Sorry - yes should have added some testing notes. Go to a single blog post and attempt to comment with an empty message and you will see the error markup.

[sbrody]

@RobjS I've rebased in the changes setting jQuery as a dependency. On doing that I discovered a couple more errors in the JavaScript caused by improper use of $ - which I have also fixed here as they are related to the commenting issue.

[RobjS]

@sbrody I'm a bit unsure what's happening here! Before you pushed the new changes, I couldn't get the errors to trigger, though I'm not sure why. But with the new changes you've pushed, I can get them to trigger even without the changes from $ to jQuery.

i.e. if I do git checkout 6930d to get just your first commit, then run yarn run grunt to re-compile the JS, the errors still work. So I think the $/jQuery change might be a red herring?

[sbrody]

@sbrody I'm a bit unsure what's happening here! Before you pushed the new changes, I couldn't get the errors to trigger, though I'm not sure why. But with the new changes you've pushed, I can get them to trigger even without the changes from $ to jQuery.

i.e. if I do git checkout 6930d to get just your first commit, then run yarn run grunt to re-compile the JS, the errors still work. So I think the $/jQuery change might be a red herring?

@RobjS yes - the errors are displaying but are you not getting the console error, which prevents the error summary box above from appearing? (Although not related to the update, I thought it was worth fixing at the same time - shall I separate it out into another PR?)

I should add - you are now seeing the error message because of the separate PR setting jquery as a dependency, which I rebased in to this PR as it's now been approved. I thought that would help with testing but it perhaps just created more confusion!

[RobjS]

Ah, that all makes sense now! LGTM 👍