Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use 303 to /wp-login.php for REST #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't use 303 to /wp-login.php for REST #36

wants to merge 1 commit into from

Conversation

leedxw
Copy link
Contributor

@leedxw leedxw commented Aug 6, 2024

We shouldn't use a redirect request for REST auth, we need to send a 401.

  • Version number has been bumped
  • Major version number tag moved after release (see docs)

@leedxw leedxw force-pushed the fix/rest_response branch 2 times, most recently from 1a73dc2 to 33909cd Compare August 7, 2024 09:05
@leedxw
Don't use 303 to /wp-login.php for REST
edc29f6 
We shouldn't use a redirect request for REST auth, we need to send a 401.
@leedxw leedxw requested a review from snim2 November 28, 2024 16:55
@leedxw leedxw marked this pull request as ready for review November 28, 2024 16:56
snim2
snim2 requested changes Nov 28, 2024
View reviewed changes
Copy link
Contributor

@snim2 snim2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll come back to this tomorrow but it needs a couple of tweaks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snim2 snim2 snim2 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leedxw @snim2