Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix update script attempting setup access early #256

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

Stretch96
Copy link
Member

  • The update script is trying to access setup.json to get the github token for dalmatian-tools, before setup has completed
  • This ensures it will not check for the token if setup is being ran

* The update script is trying to access setup.json to get the github
  token for dalmatian-tools, before setup has completed
* This ensures it will not check for the token if setup is being ran
@Stretch96 Stretch96 force-pushed the fix-update-script-attempting-setup-access-early branch from 055a315 to 6ee1601 Compare March 8, 2024 16:44
Copy link
Contributor

@olivia-work olivia-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Stretch96 Stretch96 merged commit 80039a8 into main Mar 8, 2024
2 checks passed
@Stretch96 Stretch96 deleted the fix-update-script-attempting-setup-access-early branch March 8, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants