Use DALMATIAN_CONFIG_PATH if set #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the config scripts to use DALMATIAN_CONFIG_PATH if set so that people who override the default get the correct results.
DrizzlyOwl
reviewed
Mar 1, 2024
| INFRAS=$(yq e -o=json ".infrastructures" "$APP_ROOT/bin/tmp/dalmatian-config/dalmatian.yml") | ||
| CONFIG_FILE="${DALMATIAN_CONFIG_PATH:-$APP_ROOT/bin/tmp/dalmatian-config/dalmatian.yml}" | ||
|
|
||
| INFRAS=$(yq e -o=json ".infrastructures" "$CONFIG_FILE") |
There was a problem hiding this comment.
I feel like INFRAS should be renamed to INFRASTRUCTURES for consistency but its not a blocker
DrizzlyOwl
approved these changes
Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the config scripts to use DALMATIAN_CONFIG_PATH if set so that people
who override the default get the correct results.