Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bash lib functions consistently in rename-env-var script #246

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

snim2
Copy link
Contributor

@snim2 snim2 commented Feb 12, 2024

To test, write some nonsense:

❯ dalmatian service rename-environment-variable
[!] Error: No arguments passed
Usage: rename-environment-variable [OPTIONS]
This command can rename environment variables for a service
  -h                     - help
  -i <infrastructure>    - infrastructure name
  -s <service>           - service name
  -e <environment>       - environment name (e.g. 'staging' or 'prod')
  -k <key>               - key e.g SMTP_HOST
  -n <new-key>           - new key e.g. SMTP_PORT

You should get an error message before the usage text and the exit code of the command should be non-zero.

@snim2 snim2 requested a review from DrizzlyOwl February 12, 2024 10:32
@snim2 snim2 merged commit d284a59 into main Feb 12, 2024
3 checks passed
@snim2 snim2 deleted the refactor/use-bash-lib-consistently branch February 12, 2024 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants