Check that ACF functions exist before use #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snim2
force-pushed
the
chore/avoid-acf-errors
branch
from
6ff408b to
9dfd261
Compare
If this plugin is run via a request to wp-activate.php it will produce a 5xx error in our logs. This commit checks for the existance of ACF functions before they are used, and returns early from methods if ACF is not available.
snim2
force-pushed
the
chore/avoid-acf-errors
branch
from
9dfd261 to
661fd82
Compare
RobjS
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this plugin is run via a request to wp-activate.php it will produce a 5xx error in our logs. This commit checks for the existance of ACF functions before they are used, and returns early from methods if ACF is not available.
See:
https://dxw.slack.com/archives/C04AJM8DCRF/p1738687250751619
Testing
composer install./vendor/bin/php-cs-fixer fix./vendor/bin/psalm --find-unused-psalm-suppress./vendor/bin/kahlan specChecklist