Adapting helm source --fallback #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In emacs 25 & up, helm-20170228.412, only one source is presented to the user. fallback-source doesn't work correctly. As no new timers are correctly created, recent timers do not show. fallback-source modified, by replacing (dummy) in the helm - function/macro by (helm-build-dummy-source). I'm not a programmer, and I'm neither into lisp, nor into helm. However, the code works that way on my machine. Note to David Knight: if useful, please use, and David, thank you for a lovely idea and beautiful code.
|
Confirmed, the patch also works here. Wish @dxknight would accept the pull request... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In emacs 25 & up, helm-20170228.412, only one source is presented to the user. fallback-source doesn't work correctly. As no new timers are correctly created, recent timers do not show.
fallback-source modified, by replacing (dummy) in the helm - function/macro by (helm-build-dummy-source).
I'm not a programmer, and I'm neither into lisp, nor into helm. However, the code works that way on my machine.
Note to David Knight: if useful, please use, and David, thank you for a lovely idea and beautiful code.