feat: fetch full size artist cover on tapped #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In reference to #539 |
There is a difference, depending on the server, a different ID may be used for the cover art. Also some servers may not have cover art available for the artist, which is why the |
dweymouth
requested changes
Jan 26, 2025
|
closes #539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs some more testing, since there are some things I'm not yet quite sure about
Artistmodel,IDandCoverArtIDseem to be the same thing, no? (the id's differ, but both result in the correct image)ArtistPageHeaderin itsUpdatemethod have a nil check forartist == nil, whereas, e.g.,AlbumPageHeaderdoesn't. Is this nil check even necessary?if artist.CoverArtID == ""check which I removed, as far as my testing goes it also is not required.