Fix the creation of Permutation symbols #377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcondello
commented
Sep 4, 2025
| <class 'dwave.optimization.symbols.Permutation'> | ||
| """ | ||
| def __init__(self, Constant array, ListVariable x): | ||
| def __init__(self, Constant array, ArraySymbol x): |
Member
Author
There was a problem hiding this comment.
This is the main fix, but there were a few other edge cases as well
arcondello
force-pushed
the
fix/Permutation-symbol-construction
branch
from
4a643b5 to
fcd4af1
Compare
wbernoudy
reviewed
Sep 8, 2025
| # The total operation must of the form A[i0, i1][i2, i3] | ||
|
|
||
| i0, i1 = self._iter_indices() | ||
| i2, i3 = index if isinstance(index, tuple) else (index, slice(None, None, None)) |
Member
There was a problem hiding this comment.
Assuming there are only two indices here breaks the case of A[:, x][(x,)] and makes a somewhat more confusing error for A[:, x][x, :, :].
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases we would get errors when we shouldn't.