Fix: TypeError in version comparison (map to tuple conversion) #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix console_scripts entry point in setup.py to point to pynetinstall.__main__:main - Encapsulate main execution logic into main() function in pynetinstall/__main__.py - Update README.md Usage section to reflect correct command line usage
- Convert map object to tuple before comparison to fix TypeError - This prevents '>' not supported between instances of 'map' and 'tuple' error - Affects NPK version comparison in Python 3
Collaborator
|
thanks! i'll take a look at both of your PRs when i find time for it, asap. you accidentally added the "Fix: Invalid script entry point in setup.py" commit to this PR too. please rebase. |
Author
You're very welcome! I apologize for previously submitting multiple adjustment projects together. I have now separated them and submitted them individually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Fix a TypeError that occurred during NPK version validation in Python 3 environments.
Changes Made
pynetinstall/flash.pyImpact
问题描述
修复Python 3中NPK版本比较时的TypeError。
修改内容
影响范围