Skip to content

Conversation

@jesster2k10
Copy link

I fixed the error by creating a module to replace the deprecated & removed function "alias_method_chain". Also bumped the version numbers to 1.3.0 since this may stop working with rails versions below 5

@dvandersluis dvandersluis force-pushed the master branch 6 times, most recently from 0000db2 to 540a9e2 Compare August 27, 2019 20:17
@dvandersluis
Copy link
Owner

Thank you for your PR, @jesster2k10!

I had been doing some work on a v2.0.0 (although it's been on the shelf for a while), but those commits were being merged into master, and they're not ready to be released. I've branched them off into a 2.0.0 branch and removed those commits from master, so please rebase your branch against master and squash your commits.

I've also updated the travis build matrix so that tests are being run against rails 3 through 6 (although there certainly aren't tests for everything). I relaxed the gem versions in that change, but I don't want to force >= 5.1.0 in a minor release (it's possible 2.0.0 will drop support for some older rails versions).

If possible, please add a test case for the ActiveRecord::ConnectionAdapters::Quoting to ensure it still works in all supported rails versions (3+).

Finally, please add a section for version 1.3.0 in CHANGELOG.md and note your change.

@jesster2k10
Copy link
Author

Thank you for your PR, @jesster2k10!

I had been doing some work on a v2.0.0 (although it's been on the shelf for a while), but those commits were being merged into master, and they're not ready to be released. I've branched them off into a 2.0.0 branch and removed those commits from master, so please rebase your branch against master and squash your commits.

I've also updated the travis build matrix so that tests are being run against rails 3 through 6 (although there certainly aren't tests for everything). I relaxed the gem versions in that change, but I don't want to force >= 5.1.0 in a minor release (it's possible 2.0.0 will drop support for some older rails versions).

If possible, please add a test case for the ActiveRecord::ConnectionAdapters::Quoting to ensure it still works in all supported rails versions (3+).

Finally, please add a section for version 1.3.0 in CHANGELOG.md and note your change.

Hey, just after seeing this now. Once I have the time I can get to a couple of those things you mentioned!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants