Skip to content

Ensure that the semaphore keeps working when app after lpop of available key #66

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Ensure that the semaphore keeps working when app after lpop of available key #66

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/redis/semaphore.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def initialize(name, opts = {})
def exists_or_create!
token = @redis.getset(exists_key, EXISTS_TOKEN)

if token.nil?
if token.nil? || all_tokens.empty?
create!
else
# Previous versions of redis-semaphore did not set `version_key`.
Expand Down
13 changes: 13 additions & 0 deletions spec/semaphore_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,6 +143,19 @@
expect(semaphore.locked?).to be true
end
end

it "should recover after being killed after lpop of AVAILABLE" do
semaphore.lock
semaphore.unlock

expect(semaphore.available_count). to eq(1)

@redis.lpop(semaphore.send(:available_key))

semaphore.lock(-1)

expect(semaphore.locked?).to be true
end
end

describe "semaphore with expiration" do
Expand Down