Fix empty static MCP server names - #30224
Merged
Merged
Conversation
Omit blank view names before creating static-credential MCP servers while preserving required custom-name validation for duplicate instances. Co-authored-by: Cursor <cursoragent@cursor.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
![dust-agent[bot]](https://avatars.githubusercontent.com/in/1117438?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caused by: #30107
eng runner: https://github.com/dust-tt/tasks/issues/9980
Following the addition of custom MCP server view names, first-time setup of integrations using the static-credential flow could fail with:
The connection-name field is hidden for a first server instance and defaults to an empty string. The standard MCP creation flow trims and omits that value, but the static-credential flow forwarded
viewName: ""directly to the API. The backend interpreted it as an explicitly supplied name and correctly rejected it.This affected integrations using the static-credential creation path, while integrations following the standard creation flow continued to work.
Testing
Risk
Low - Fixing issue
Deploy