[front] enh: nest pod conversations and fix pod title cursor in inbox - #30223
Open
smb2268 wants to merge 8 commits into
Open
[front] enh: nest pod conversations and fix pod title cursor in inbox#30223smb2268 wants to merge 8 commits into
smb2268 wants to merge 8 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
Contributor
|
🚀 App SPA preview deployed |
smb2268
force-pushed
the
sarah/inbox-pod-hierarchy
branch
from
August 7, 2026 21:30
10819c5 to
c64951c
Compare
smb2268
marked this pull request as ready for review
August 7, 2026 21:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Targeted improvements to the unread/inbox sections of the conversation sidebar (
UnreadConversationsSection):cursor-default select-none(no more text I-beam suggesting interactivity) and drops its built-inbg-app-backgroundso it sits flush on the section card. ItsisStickywas removed: sticky was already inert here (anoverflow-hiddenancestor between the label and the scroll viewport disables it).pl-3), so the row and its hover background read as nested inside the pod group. Non-pod conversations stay flush; the indent also applies in multi-select mode.has-[[data-mark-read=pod]:hover]/:focus-visible— no hover state in React. To support this, each pod group now has a real wrapper element (group-levelmotion.div+ nestedAnimatePresencefor per-conversation exits); a side effect is that clearing a whole pod collapses the header together with its conversations instead of the header popping out. The section-level "Mark all as read" intentionally has no highlight — it felt too heavy across the whole card.isLoadingwas a single shared flag wired to every mark-as-read button (pre-existing), so clicking one spun them all. Only the clicked button spins now, tracked per scope ("all"or the pod'sspaceId) with a concurrency-safe clear (a finishing request only clears its own scope).useMarkAllConversationsAsReadnow awaits the pod cache revalidations (Promise.allSettled) before resolving, so the spinner holds until the refreshed data lands and the rows animate out, instead of clearing a beat early. This also applies to the same button inPodConversationsTab(the hook's only other consumer). The success toast intentionally fires before the await so feedback isn't coupled to refetch latency.First step of a larger inbox-hierarchy cleanup (pod header vs. conversation visual treatment, possibly a clickable pod header later).
Tests
tsgo --noEmiton front passes; biome clean.Risk
Low — UI-only change scoped to the sidebar unread sections plus a resolve-timing change in the mark-as-read hook. Worst case, the unread sections render oddly or spinners linger. Safe to rollback.
Deploy Plan
Standard front deploy.