Skip to content

Conversation

jonathanKingston
Copy link
Contributor

@jonathanKingston jonathanKingston commented Oct 11, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/project/72649045549333/task/1211616117314246?focus=true

Description

  • Allows logs to work as expected whilst in the duck.ai sidebar (no using the wrapped console.js from SERP which provides the wrong log lines).
  • Passes through the logger into the bridge construction.
  • Adds some basic logging into the bridge messaging to allow for easier debug of the page-world side of the conversation.

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Adds captured console bindings and passes feature logger into the page-world message bridge with concise lifecycle logs.

  • Logging:
    • Capture console from globalThis and export consoleLog, consoleWarn, consoleError in injected/src/captured-globals.js.
    • Use captured console methods in injected/src/content-feature.js logger to ensure correct call sites.
  • Message Bridge (injected/src/features/message-bridge/create-page-world-bridge.js):
    • Accept an optional context (feature instance) in createPageWorldBridge and createMessagingInterface.
    • Add contextual log.info calls for notify, request (including response), and subscribe events.
  • Navigator Interface (injected/src/features/navigator-interface.js):
    • Pass the feature context into createPageWorldBridge when constructing bridges.

Written by Cursor Bugbot for commit 532110e. This will update automatically on new commits. Configure here.

Copy link

netlify bot commented Oct 11, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 532110e
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68ed78864de473000871adfe
😎 Deploy Preview https://deploy-preview-2004--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 11, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 11, 2025

[Beta] Generated file diff

Time updated: Mon, 13 Oct 2025 22:09:51 GMT

Android
    - android/adsjsContentScope.js
  • android/autofillImport.js
  • android/brokerProtection.js
  • android/contentScope.js
  • android/pages/duckplayer/dist/index.js

File has changed

Apple
    - apple/contentScope.js
  • apple/contentScopeIsolated.js
  • apple/pages/duckplayer/dist/index.js
  • apple/pages/duckplayer/index.html
  • apple/pages/history/dist/index.js
  • apple/pages/new-tab/dist/index.js
  • apple/pages/onboarding/dist/index.js
  • apple/pages/release-notes/dist/index.js
  • apple/pages/special-error/dist/index.js
  • apple/pages/special-error/index.html

File has changed

Chrome-mv3
    - chrome-mv3/inject.js

File has changed

Firefox
    - firefox/inject.js

File has changed

Integration
    - integration/contentScope.js
  • integration/pages/duckplayer/dist/index.js
  • integration/pages/example/dist/index.js
  • integration/pages/history/dist/index.js
  • integration/pages/new-tab/dist/index.js
  • integration/pages/onboarding/dist/index.js
  • integration/pages/release-notes/dist/index.js
  • integration/pages/special-error/dist/index.js

File has changed

Windows
    - windows/contentScope.js
  • windows/pages/duckplayer/dist/index.js
  • windows/pages/history/dist/index.js
  • windows/pages/new-tab/dist/index.js
  • windows/pages/onboarding/dist/index.js
  • windows/pages/release-notes/dist/index.js
  • windows/pages/special-error/dist/index.js
  • windows/pages/special-error/index.html

File has changed

@jonathanKingston jonathanKingston marked this pull request as ready for review October 11, 2025 21:19
@jonathanKingston jonathanKingston requested a review from a team as a code owner October 11, 2025 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants