Skip to content

Conversation

dbajpeyi
Copy link
Contributor

@dbajpeyi dbajpeyi commented Oct 9, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211588662115293?focus=true

Description

  • Increase sleep before attempting download
  • Poll for the download link forever

Testing Steps

Checklist

Please tick all that apply:

  • I have tested this change locally
  • I have tested this change locally in all supported browsers
  • This change will be visible to users
  • I have added automated tests that cover this change
  • I have ensured the change is gated by config
  • This change was covered by a ship review
  • This change was covered by a tech design
  • Any dependent config has been merged

Note

Refactors downloadData to robustly find user/export IDs and download link using configurable retries, URL-based user parsing, and early error handling.

  • Bookmark Import (injected/src/features/autofill-import.js)
    • Refactor downloadData:
      • Replace fixed sleep with runWithRetry using downloadRetryLimit and downloadRetryInterval (defaults to Infinity/1000ms).
      • Find user ID via selector retry and parse from URL (URL.searchParams).
      • Early exit with actionCompleted error if user/export ID missing (message text updated).
      • Retry until archive link is present, then trigger download via constructed TAKEOUT_DOWNLOAD_URL_BASE URL.

Written by Cursor Bugbot for commit 3c9bd82. This will update automatically on new commits. Configure here.

Copy link

netlify bot commented Oct 9, 2025

Deploy Preview for content-scope-scripts ready!

Name Link
🔨 Latest commit 3c9bd82
🔍 Latest deploy log https://app.netlify.com/projects/content-scope-scripts/deploys/68efce22d969cb0008d748cf
😎 Deploy Preview https://deploy-preview-2001--content-scope-scripts.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link

github-actions bot commented Oct 9, 2025

Temporary Branch Update

The temporary branch has been updated with the latest changes. Below are the details:

Please use the above install command to update to the latest version.

Copy link

github-actions bot commented Oct 9, 2025

[Beta] Generated file diff

Time updated: Wed, 15 Oct 2025 16:39:49 GMT

Android
    - android/autofillImport.js

File has changed

Integration
    - integration/contentScope.js

File has changed

@dbajpeyi dbajpeyi changed the title fix: add retry to userId parsing and a longer sleep before download [Google import] Add resilience to download data Oct 10, 2025
@dbajpeyi dbajpeyi marked this pull request as ready for review October 10, 2025 12:13
@dbajpeyi dbajpeyi requested a review from a team as a code owner October 10, 2025 12:13
cursor[bot]

This comment was marked as outdated.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/autofill-import-retry-user-id branch from 713728f to a8abee0 Compare October 15, 2025 14:24
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/autofill-import-retry-user-id branch 3 times, most recently from fcae88b to ef09144 Compare October 15, 2025 15:44
@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/autofill-import-retry-user-id branch from ef09144 to fb401e0 Compare October 15, 2025 15:45
cursor[bot]

This comment was marked as outdated.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/autofill-import-retry-user-id branch from dc5c1c0 to 55609c5 Compare October 15, 2025 16:30
cursor[bot]

This comment was marked as outdated.

@dbajpeyi dbajpeyi force-pushed the dbajpeyi/fix/autofill-import-retry-user-id branch from 363dc70 to 04c9fda Compare October 15, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants