Bugfix 547 windrose legend - #554
Merged
Merged
Conversation
…Create the intermediate directory if it doesn't already exist.
…lue exceeds the maximum mean error wind speed
CPKalb
approved these changes
Dec 10, 2025
CPKalb
left a comment
Contributor
There was a problem hiding this comment.
I apparently don't have conda set up to work on dakota. So, I pulled these to another machine and ran the suggested testing. The results matched the wind rose with the correct legend. I also ran a test on some ACOM data and it behaved as expected.
24 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
on local host (Mac OS):
using this YAML config file:
wind_rose_custom_points.yaml.txt
and data:
point_stat_mpr.txt
and on 'dakota':
/d3/projects/WindRose
generates a wind rose plot that no longer generates this erroneous plot (see below):
and generates a plot with a correct legend:
Run on dakota and verify that the plot is correct and the generated point_stat_mpr.points1 file no longer has a data line for Wind 20-16:
source ./setup_env.bash(to set up the PYTHONPATH and TEST_DIR env variables)conda activate /d3/personal/mwin/miniforge3/envs/METviewer_py3.12cd $PLOTPY/metplotpy/plots/wind_rosepython wind_rose.py wind_rose_custom_points.yamlWind 20-16 m/s: 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [NA]
Will this PR result in changes to the test suite? [NA]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Maybe]
If yes, please describe:
may not conform to code coverage threshold
Please complete this pull request review by [before 7.0 beta1 ].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases