Skip to content

Bugfix 547 windrose legend - #554

Merged
bikegeek merged 3 commits into
developfrom
bugfix_547_windrose_legend
Dec 13, 2025
Merged

Bugfix 547 windrose legend#554
bikegeek merged 3 commits into
developfrom
bugfix_547_windrose_legend

Conversation

@bikegeek

@bikegeek bikegeek commented Dec 5, 2025

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

on local host (Mac OS):

using this YAML config file:

wind_rose_custom_points.yaml.txt

and data:
point_stat_mpr.txt

and on 'dakota':

/d3/projects/WindRose

generates a wind rose plot that no longer generates this erroneous plot (see below):

wind_rose_custom_points

and generates a plot with a correct legend:

corrected_wind_rose_custom_points
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

Run on dakota and verify that the plot is correct and the generated point_stat_mpr.points1 file no longer has a data line for Wind 20-16:

  1. Run in bash
  2. cd to /d3/projects/WindRose
  3. source ./setup_env.bash (to set up the PYTHONPATH and TEST_DIR env variables)
  4. conda activate /d3/personal/mwin/miniforge3/envs/METviewer_py3.12
  5. cd $PLOTPY/metplotpy/plots/wind_rose
  6. python wind_rose.py wind_rose_custom_points.yaml
  7. go to the $TEST_DIR/intermediate_files directory and verify the generated plot matches the one in the $TEST_DIR/intermediate_files/mwin_points
  8. verify that the generated point_stat_mpr_points1 matches the one in the $TEST_DIR/intermediate_files/mwin_points directory and does NOT contain this data:

Wind 20-16 m/s: 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000 0.000000

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [NA]

  • Will this PR result in changes to the test suite? [NA]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Maybe]

    If yes, please describe:
    may not conform to code coverage threshold

  • Please complete this pull request review by [before 7.0 beta1 ].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…Create the intermediate directory if it doesn't already exist.
…lue exceeds the maximum mean error wind speed
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Dec 5, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-13.0 Development Dec 5, 2025
@bikegeek bikegeek added this to the METplotpy-4.0.0 milestone Dec 5, 2025
@bikegeek
bikegeek requested a review from CPKalb December 5, 2025 22:40

@CPKalb CPKalb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I apparently don't have conda set up to work on dakota. So, I pulled these to another machine and ran the suggested testing. The results matched the wind rose with the correct legend. I also ran a test on some ACOM data and it behaved as expected.

@bikegeek
bikegeek merged commit b5af67f into develop Dec 13, 2025
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from 🟢 Ready to 🏁 Done in METplus-13.0 Development Dec 13, 2025
@bikegeek
bikegeek deleted the bugfix_547_windrose_legend branch February 20, 2026 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Bugfix- WindRose plot shows incorrect legend when max wind speed is less than requested

2 participants