Skip to content

Feature 539 env support - #543

Merged
bikegeek merged 5 commits into
developfrom
feature_539_env_support
Sep 2, 2025
Merged

Feature 539 env support#543
bikegeek merged 5 commits into
developfrom
feature_539_env_support

Conversation

@bikegeek

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    on 'seneca', under the /d1/projects/PLOTTING_ENV_SUPPORT directory:
    generated plot using METcalcpy with changes and run tests for all plots

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    None, due to testing done for METcalcpy PR#454

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]

  • Do these changes include sufficient testing updates? [YES]

    • testing configuration files update
  • Will this PR result in changes to the test suite? [Yes or No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [Yes]

    If yes, please describe:
    Quality Gate fails due to coverage values falling below threshold

  • Please complete this pull request review by [before 6.2 RC1 release].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@bikegeek
bikegeek requested a review from CPKalb August 28, 2025 17:54
@bikegeek bikegeek added this to the METplotpy-3.2.0 milestone Aug 28, 2025
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-6.2 Development Aug 28, 2025
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-6.2 Development Aug 28, 2025
@bikegeek bikegeek linked an issue Aug 28, 2025 that may be closed by this pull request
23 tasks

@CPKalb CPKalb left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and new environment variable options work as needed.

@bikegeek
bikegeek merged commit d7c1e2a into develop Sep 2, 2025
6 of 7 checks passed
@github-project-automation github-project-automation Bot moved this from 🟢 Ready to 🏁 Done in METplus-6.2 Development Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Add Support for Environment Variables as variable names in Line plotting yaml files

2 participants