Feature 539 env support - #543
Merged
Merged
Conversation
…t points generated using env vars for FCST_VAR_VAL1/2
…responding stat values
23 tasks
CPKalb
approved these changes
Aug 29, 2025
CPKalb
left a comment
Contributor
There was a problem hiding this comment.
Tested and new environment variable options work as needed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
on 'seneca', under the /d1/projects/PLOTTING_ENV_SUPPORT directory:
generated plot using METcalcpy with changes and run tests for all plots
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
None, due to testing done for METcalcpy PR#454
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [YES]
Will this PR result in changes to the test suite? [Yes or No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Yes]
If yes, please describe:
Quality Gate fails due to coverage values falling below threshold
Please complete this pull request review by [before 6.2 RC1 release].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases