upgrade to kaleido 1.0 - #520
Closed
bikegeek wants to merge 9 commits into
Closed
Conversation
* Making index consistent with other METplus repositories * Initial commit of overview
comment out the pio.kaleido.scope line, this is now causing tests to fail due to kaleido warning for deprecations in September 2025
backing out the latest from pio.kaleido line. WARNING: GHA tests may fail due to upcoming deprecation and warnings that emanate due to Python 3.12 still features that will be deprecated.
Tests pass outside of GHA. Something in GHA is causing issues with Python 3.12 and kaleido (causes AssertionError in kaleido)
bikegeek
marked this pull request as draft
June 28, 2025 23:11
bikegeek
marked this pull request as ready for review
June 29, 2025 00:41
* Update conf.py update version for 3.20 beta1 development * Feature 504 installation files (#511) * Update Orion file for Python 3.12 * Per #504, updating Casper file for Python 3.12 * Per # 504, updating compiler for Orion * Per #504, updating hera file for Python 3.12 * Per #504, updating jet file for Python 3.12 * Feature METplus2857 support (#513) * Making index consistent with other METplus repositories * Initial commit of overview * Bugfix #515 develop - remove deprecated import (#517) * Per #515, remove deprecated import * remove additional unused import to resolve SQ * Update base_plot.py Comment out pio.kaleido.scope.chromium line. Python 3.12 updates with updated deprecations in kaleido will cause some tests to fail due to these warnings. * Remove soon to be deprecated call to plotly.io.kaleido.scope * Comment out soon-to-be deprecated call to plolty.io.kaleido.scope * add call to install chrome * Add test_* to trigger and setup test to use test_requirements.txt * To test plotly/kaleido updates * Try using kaleido_get_chrome_sync * Update import to use ploty.io._kaleido * Using latest import, invoke the get_chrome() method instead of get_chrome_sync() * explicitly pip install kaleido 1.0 * Add Google Chrome action * fix syntax error * remove - from the run command * Explicitly get the Chrome environment, bypass the calls to plotly.io.kaleido for installing chrome, which already exists * Set up a CHROME_INSTALL path and save it as an environment * remove no-sudo * removed extra line at top of file * move env definition by indenting * Removed all imports that didn't work and the soon to be deprecated reference to kaleido.scope. Running after installing Chrome without setting an ENV variable. * Remove any attempt to set an env * Remove the --version to the path under the chrome installation * Remove skip * Update test_requirements.txt match up with requirements.txt except for kaleido and plotly * Attempt to get chrome via kaleido.get_chrome_sync() * Update unit_tests.yaml Comment out installation of Chrome for now but don't delete it in the event that Chrome will need to be explicitly available. * Update base_plot.py Remove old comment and update to reflect upcoming changes to kaleido * Replace test_requirements.txt with requirements.txt * Update Plotly from 6.0.0 to 6.1.1 and kaleido from 0.2.1 to 1.0.0 * Adding modulefile for new machine ursa --------- Co-authored-by: Julie Prestopnik <jpresto@ucar.edu> Co-authored-by: George McCabe <23407799+georgemccabe@users.noreply.github.com>
bikegeek
marked this pull request as draft
July 11, 2025 21:20
github-project-automation
Bot
moved this from 🔎 In review
to 🏁 Done
in METplus-6.2 Development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
testing with Command line and IDE
verified GHA unit tests are passing
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
verify unit tests are passing
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NA]
Do these changes include sufficient testing updates? [NA]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [Maybe]
If yes, please describe:
May have code coverage results below threshold
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases