Skip to content

Issue 457 sonarqube - #476

Merged
bikegeek merged 5 commits into
developfrom
issue_457_sonarqube
Jul 29, 2026
Merged

Issue 457 sonarqube#476
bikegeek merged 5 commits into
developfrom
issue_457_sonarqube

Conversation

@bikegeek

@bikegeek bikegeek commented Jul 29, 2026

Copy link
Copy Markdown
Collaborator

Pull Request Testing

  • Describe testing already performed for these changes:

    Generated tests to verify that new regex no longer raises SonarQube DOS (Denial of Service) warning due to polynomial runtime due to backtracking

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    verify all tests are passing

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [NAo]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Before August 4].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METcalcpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

bikegeek added 5 commits July 29, 2026 15:06
… and addresses a potential Denial of Service as a result of polynomial runtime due to backtracking. This newer regular expression also finds matches in fewer steps.
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jul 29, 2026
@bikegeek bikegeek moved this from 🩺 Needs Triage to 🟢 Ready in METplus-13.0 Development Jul 29, 2026
@bikegeek bikegeek added this to the METcalcpy-13.0.0 milestone Jul 29, 2026
@bikegeek bikegeek linked an issue Jul 29, 2026 that may be closed by this pull request
22 tasks

@mollybsmith-noaa mollybsmith-noaa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bikegeek
bikegeek merged commit ab3c822 into develop Jul 29, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from 🟢 Ready to 🏁 Done in METplus-13.0 Development Jul 29, 2026
@bikegeek
bikegeek deleted the issue_457_sonarqube branch July 29, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

Resolve 1 SonarQube Security issue in METcalcpy's develop branch

2 participants