Skip to content

Feature 3406 negative value with at #3420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hsoh-u merged 19 commits into from
Jul 22, 2026
Merged

Feature 3406 negative value with at #3420

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
ab70878
#3406 Added var_info_nc.cc and var_info_nc.h
Jul 7, 2026
f9f0486
#3406 Cleanup for SonarQube
Jul 14, 2026
582cb99
#3406 Better handling if a requested veriable does not exist
Jul 14, 2026
b65b75f
#3406 Better handling if a requested veriable does not exist. Added g…
Jul 14, 2026
167c413
#3406 Added get_index_at_nc_data
Jul 14, 2026
7186444
#3406 Separated the common codes to var_info_nc.cc and var_info_nc.h
Jul 14, 2026
5cf1128
#3406 Collected the common codes and support negatiove value for slicing
Jul 14, 2026
09ac146
Merge remote-tracking branch 'origin/develop' into feature_3406_negat…
Jul 14, 2026
aff8e90
#3406 Resolved SonarQube findings
Jul 17, 2026
1a84ad9
#3406 Resolved merge conflicts
Jul 17, 2026
a2b5c91
#3406 Added missing semicolon
Jul 17, 2026
38e3c10
#3406 Changed an offset 0 to a negative value
Jul 17, 2026
b2a1f63
Reurn false instead of excit when the requested variable does not exit
Jul 20, 2026
266f5da
#3406 Move the comment to the right place
Jul 21, 2026
4a3af15
#3406 Separated get_real_dimension
Jul 21, 2026
547b6be
#3406 Continue for derived variable when the requested variable does …
Jul 21, 2026
de7617f
#3406 Hanlding negative offset
Jul 21, 2026
26be78f
#3406 Changed Error message to Warning
Jul 21, 2026
14bc93c
#3406 Delete duplicated definition
Jul 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion internal/test_unit/xml/unit_plot_data_plane.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -657,7 +657,7 @@
<param> \
&DATA_DIR_MODEL;/wrf/wrfout_solarwind_d02_2019-08-31_12:00:00 \
&OUTPUT_DIR;/plot_data_plane/wrf_num_z_levels_stag.ps \
'name="RH_ZL"; level="(0,0,*,*)";' \
'name="RH_ZL"; level="(0,@-78,*,*)";' \
-title "Relative Humidity Z-level (num_z_levels_stag)" \
-v 1
</param>
Expand Down
1 change: 1 addition & 0 deletions src/libcode/vx_data2d/Makefile.am
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ libvx_data2d_a_SOURCES = \
leveltype_to_string.cc leveltype_to_string.h \
level_info.cc level_info.h \
var_info.cc var_info.h \
var_info_nc.cc var_info_nc.h \
var_info_pairs.cc var_info_pairs.h \
data_class.cc data_class.h \
data2d_utils.cc data2d_utils.h \
Expand Down
20 changes: 20 additions & 0 deletions src/libcode/vx_data2d/Makefile.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,7 @@ am_libvx_data2d_a_OBJECTS = \
libvx_data2d_a-leveltype_to_string.$(OBJEXT) \
libvx_data2d_a-level_info.$(OBJEXT) \
libvx_data2d_a-var_info.$(OBJEXT) \
libvx_data2d_a-var_info_nc.$(OBJEXT) \
libvx_data2d_a-var_info_pairs.$(OBJEXT) \
libvx_data2d_a-data_class.$(OBJEXT) \
libvx_data2d_a-data2d_utils.$(OBJEXT) \
Expand Down Expand Up @@ -139,6 +140,7 @@ am__depfiles_remade = ./$(DEPDIR)/libvx_data2d_a-data2d_utils.Po \
./$(DEPDIR)/libvx_data2d_a-mask_filters.Po \
./$(DEPDIR)/libvx_data2d_a-table_lookup.Po \
./$(DEPDIR)/libvx_data2d_a-var_info.Po \
./$(DEPDIR)/libvx_data2d_a-var_info_nc.Po \
./$(DEPDIR)/libvx_data2d_a-var_info_pairs.Po
am__mv = mv -f
AM_V_lt = $(am__v_lt_@AM_V@)
Expand Down Expand Up @@ -357,6 +359,7 @@ libvx_data2d_a_SOURCES = \
leveltype_to_string.cc leveltype_to_string.h \
level_info.cc level_info.h \
var_info.cc var_info.h \
var_info_nc.cc var_info_nc.h \
var_info_pairs.cc var_info_pairs.h \
data_class.cc data_class.h \
data2d_utils.cc data2d_utils.h \
Expand Down Expand Up @@ -420,6 +423,7 @@ distclean-compile:
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libvx_data2d_a-mask_filters.Po@am__quote@ # am--include-marker
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libvx_data2d_a-table_lookup.Po@am__quote@ # am--include-marker
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libvx_data2d_a-var_info.Po@am__quote@ # am--include-marker
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libvx_data2d_a-var_info_nc.Po@am__quote@ # am--include-marker
@AMDEP_TRUE@@am__include@ @am__quote@./$(DEPDIR)/libvx_data2d_a-var_info_pairs.Po@am__quote@ # am--include-marker

$(am__depfiles_remade):
Expand Down Expand Up @@ -484,6 +488,20 @@ libvx_data2d_a-var_info.obj: var_info.cc
@AMDEP_TRUE@@am__fastdepCXX_FALSE@ DEPDIR=$(DEPDIR) $(CXXDEPMODE) $(depcomp) @AMDEPBACKSLASH@
@am__fastdepCXX_FALSE@ $(AM_V_CXX@am__nodep@)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -c -o libvx_data2d_a-var_info.obj `if test -f 'var_info.cc'; then $(CYGPATH_W) 'var_info.cc'; else $(CYGPATH_W) '$(srcdir)/var_info.cc'; fi`

libvx_data2d_a-var_info_nc.o: var_info_nc.cc
@am__fastdepCXX_TRUE@ $(AM_V_CXX)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -MT libvx_data2d_a-var_info_nc.o -MD -MP -MF $(DEPDIR)/libvx_data2d_a-var_info_nc.Tpo -c -o libvx_data2d_a-var_info_nc.o `test -f 'var_info_nc.cc' || echo '$(srcdir)/'`var_info_nc.cc
@am__fastdepCXX_TRUE@ $(AM_V_at)$(am__mv) $(DEPDIR)/libvx_data2d_a-var_info_nc.Tpo $(DEPDIR)/libvx_data2d_a-var_info_nc.Po
@AMDEP_TRUE@@am__fastdepCXX_FALSE@ $(AM_V_CXX)source='var_info_nc.cc' object='libvx_data2d_a-var_info_nc.o' libtool=no @AMDEPBACKSLASH@
@AMDEP_TRUE@@am__fastdepCXX_FALSE@ DEPDIR=$(DEPDIR) $(CXXDEPMODE) $(depcomp) @AMDEPBACKSLASH@
@am__fastdepCXX_FALSE@ $(AM_V_CXX@am__nodep@)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -c -o libvx_data2d_a-var_info_nc.o `test -f 'var_info_nc.cc' || echo '$(srcdir)/'`var_info_nc.cc

libvx_data2d_a-var_info_nc.obj: var_info_nc.cc
@am__fastdepCXX_TRUE@ $(AM_V_CXX)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -MT libvx_data2d_a-var_info_nc.obj -MD -MP -MF $(DEPDIR)/libvx_data2d_a-var_info_nc.Tpo -c -o libvx_data2d_a-var_info_nc.obj `if test -f 'var_info_nc.cc'; then $(CYGPATH_W) 'var_info_nc.cc'; else $(CYGPATH_W) '$(srcdir)/var_info_nc.cc'; fi`
@am__fastdepCXX_TRUE@ $(AM_V_at)$(am__mv) $(DEPDIR)/libvx_data2d_a-var_info_nc.Tpo $(DEPDIR)/libvx_data2d_a-var_info_nc.Po
@AMDEP_TRUE@@am__fastdepCXX_FALSE@ $(AM_V_CXX)source='var_info_nc.cc' object='libvx_data2d_a-var_info_nc.obj' libtool=no @AMDEPBACKSLASH@
@AMDEP_TRUE@@am__fastdepCXX_FALSE@ DEPDIR=$(DEPDIR) $(CXXDEPMODE) $(depcomp) @AMDEPBACKSLASH@
@am__fastdepCXX_FALSE@ $(AM_V_CXX@am__nodep@)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -c -o libvx_data2d_a-var_info_nc.obj `if test -f 'var_info_nc.cc'; then $(CYGPATH_W) 'var_info_nc.cc'; else $(CYGPATH_W) '$(srcdir)/var_info_nc.cc'; fi`

libvx_data2d_a-var_info_pairs.o: var_info_pairs.cc
@am__fastdepCXX_TRUE@ $(AM_V_CXX)$(CXX) $(DEFS) $(DEFAULT_INCLUDES) $(INCLUDES) $(libvx_data2d_a_CPPFLAGS) $(CPPFLAGS) $(AM_CXXFLAGS) $(CXXFLAGS) -MT libvx_data2d_a-var_info_pairs.o -MD -MP -MF $(DEPDIR)/libvx_data2d_a-var_info_pairs.Tpo -c -o libvx_data2d_a-var_info_pairs.o `test -f 'var_info_pairs.cc' || echo '$(srcdir)/'`var_info_pairs.cc
@am__fastdepCXX_TRUE@ $(AM_V_at)$(am__mv) $(DEPDIR)/libvx_data2d_a-var_info_pairs.Tpo $(DEPDIR)/libvx_data2d_a-var_info_pairs.Po
Expand Down Expand Up @@ -687,6 +705,7 @@ distclean: distclean-am
-rm -f ./$(DEPDIR)/libvx_data2d_a-mask_filters.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-table_lookup.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info_nc.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info_pairs.Po
-rm -f Makefile
distclean-am: clean-am distclean-compile distclean-generic \
Expand Down Expand Up @@ -740,6 +759,7 @@ maintainer-clean: maintainer-clean-am
-rm -f ./$(DEPDIR)/libvx_data2d_a-mask_filters.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-table_lookup.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info_nc.Po
-rm -f ./$(DEPDIR)/libvx_data2d_a-var_info_pairs.Po
-rm -f Makefile
maintainer-clean-am: distclean-am maintainer-clean-generic
Expand Down
Loading
Loading