Skip to content

Bugfix 3406 negative value with at main v12.2#3419

Merged
hsoh-u merged 5 commits into
main_v12.2from
bugfix_3406_negative_value_with_at_main_v12.2
Jul 22, 2026
Merged

Bugfix 3406 negative value with at main v12.2#3419
hsoh-u merged 5 commits into
main_v12.2from
bugfix_3406_negative_value_with_at_main_v12.2

Conversation

@hsoh-u

@hsoh-u hsoh-u commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Expected Differences

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

Note: the invalid variable name is not supported for bugfix.

/d1/personal/hsoh/git/bugfixes/bugfix_3406_negative_value_with_at_main_v12.2/MET/bin/plot_data_plane /d1/personal/mccabe/wrf_renewable/wrf/20250406_06/wrfout/wrfout_zlev_d01_2025-04-07_12:00:00 plot_range.ps 'name="S_ZL"; level="(0,@-100--500,*,*)";' -v 7

DEBUG 7: get_index_at_nc_data(min,max) -> Found value -100.00000 (index=1) at Z_ZL by dimension name "num_z_levels_stag"
  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]

  • Do these changes include sufficient testing updates? [No]

  • Will this PR result in changes to the MET test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Will this PR result in changes to existing METplus Use Cases? [No]

    If yes, create a new Update Truth METplus issue to describe them.

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Fill in date].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@hsoh-u hsoh-u added this to the MET-12.2.2 (bugfix) milestone Jul 21, 2026
@hsoh-u
hsoh-u requested a review from georgemccabe July 21, 2026 15:20
@hsoh-u hsoh-u moved this from 🩺 Needs Triage to 🔎 In review in Coordinated METplus-6.2 Support Jul 21, 2026
@hsoh-u hsoh-u linked an issue Jul 21, 2026 that may be closed by this pull request
22 tasks
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
18.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@georgemccabe georgemccabe left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the failing plot_data_plane and point_stat commands using the version built on seneca for this branch (main_v12.2) and confirmed that it now works as expected. Thank you!

@hsoh-u
hsoh-u merged commit 8afca76 into main_v12.2 Jul 22, 2026
40 of 42 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🏁 Done in Coordinated METplus-6.2 Support Jul 22, 2026
@hsoh-u
hsoh-u deleted the bugfix_3406_negative_value_with_at_main_v12.2 branch July 22, 2026 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Enhance @value NetCDF dimension lookup logic to support negative values

2 participants