Bugfix #3381 develop mpas latitude#3417
Conversation
|
The feature branch was outdated. The latest develop branch was merged. |
|
jprestop
left a comment
There was a problem hiding this comment.
Thanks for this fix @hsoh-u. I reviewed the code changes, ensured all tests passed (minus the SonarQube failure which is not new), and reviewed the new log output. I appreciate that the log message makes the important distinction between a genuine data problem and harmless rounding: adjusted 0 (2) latitudes clearly separates the total number of clamped values (2) from those adjusted beyond expected float-precision tolerance (0), so it's immediately clear these were benign float→double artifacts rather than bad input data. Approved.



Expected Differences
Check and modify latitudes within -90.0 and 90.0 from radian units.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release