Bugfix #3381 main_v12.2 mpas latitude#3414
Merged
Merged
Conversation
added 2 commits
July 8, 2026 02:21
|
23 tasks
Collaborator
jprestop
approved these changes
Jul 15, 2026
jprestop
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for this fix @hsoh-u. I reviewed the code changes, ensured no errors, and reviewed the new log output. I appreciate that the log message makes the important distinction between a genuine data problem and harmless rounding: adjusted 0 (2) latitudes clearly separates the total number of clamped values (2) from those adjusted beyond expected float-precision tolerance (0), so it's immediately clear these were benign float→double artifacts rather than bad input data. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Expected Differences
Check and modify latitudes within -90.0 and 90.0 from radian units.
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
The meaning of the log message:
adjusted 0 (2) latitudes.Total 2 latitude values were adjusted to -90 or 90.
0 latitudes were converted to -90 or 90 beyond the float prevision difference
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [No]
Do these changes include sufficient testing updates? [No]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Fill in date].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release