Skip to content

Bugfix #3358 main_v12.2 stageIV #3413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
JohnHalleyGotway wants to merge 3 commits into
base: main_v12.2
Choose a base branch
from
Draft

Bugfix #3358 main_v12.2 stageIV #3413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f360a98
Per #3358, let polar stereographic data be flipped from north to sout…
JohnHalleyGotway Jul 8, 2026
c3bcd4f
Per #3358, update NetCDF library code to do case-insensitive checking…
JohnHalleyGotway Jul 8, 2026
7052799
Per #3358, switch to setting y based on the sign of dy_km instead of …
JohnHalleyGotway Jul 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 16 additions & 10 deletions src/libcode/vx_data2d_nc_cf/nc_cf_file.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,6 +1685,7 @@ void NcCfFile::get_grid_mapping_lambert_azimuthal_equal_area(const NcVar *grid_m
<< "assuming meters.\n\n";
}
else {
x_coord_units_name.set_lower();
if ( x_coord_units_name == "m" ||
x_coord_units_name == "meter" ||
x_coord_units_name == "meters") x_coord_to_m_cf = 1.0;
Expand All @@ -1710,6 +1711,7 @@ void NcCfFile::get_grid_mapping_lambert_azimuthal_equal_area(const NcVar *grid_m
<< "assuming meters.\n\n";
}
else {
y_coord_units_name.set_lower();
if ( y_coord_units_name == "m" ||
y_coord_units_name == "meter" ||
y_coord_units_name == "meters" ) y_coord_to_m_cf = 1.0;
Expand Down Expand Up @@ -1953,6 +1955,7 @@ void NcCfFile::get_grid_mapping_lambert_conformal_conic(const NcVar *grid_mappin
<< "assuming meters.\n\n";
}
else {
x_coord_units_name.set_lower();
if ( x_coord_units_name == "m" ||
x_coord_units_name == "meter" ||
x_coord_units_name == "meters") x_coord_to_m_cf = 1.0;
Expand All @@ -1977,6 +1980,7 @@ void NcCfFile::get_grid_mapping_lambert_conformal_conic(const NcVar *grid_mappin
<< "assuming meters.\n\n";
}
else {
y_coord_units_name.set_lower();
if ( y_coord_units_name == "m" ||
y_coord_units_name == "meter" ||
y_coord_units_name == "meters" ) y_coord_to_m_cf = 1.0;
Expand Down Expand Up @@ -2352,6 +2356,7 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
<< "assuming meters.\n\n";
}
else {
x_coord_units_name.set_lower();
if ( x_coord_units_name == "m" ||
x_coord_units_name == "meter" ||
x_coord_units_name == "meters") x_coord_to_m_cf = 1.0;
Expand All @@ -2377,6 +2382,7 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
<< "assuming meters.\n\n";
}
else {
y_coord_units_name.set_lower();
if ( y_coord_units_name == "m" ||
y_coord_units_name == "meter" ||
y_coord_units_name == "meters" ) y_coord_to_m_cf = 1.0;
Expand Down Expand Up @@ -2440,7 +2446,7 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
data.hemisphere = (proj_origin_lat > 0 ? 'N' : 'S');
data.x_pin = x_pin;
data.y_pin = y_pin;
data.scale_lat = proj_origin_lat;
data.scale_lat = proj_standard_parallel;
data.lon_orient = -1.0 * proj_vertical_lon;
data.d_km = dx_m / m_per_km;
data.dy_km = dy_m / m_per_km;
Expand All @@ -2454,12 +2460,6 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
double false_north = 0.;
double scale_factor = proj_origin_scale_factor;
if(!has_scale_factor && has_standard_parallel) {
double lat;
double lon;
double x;
double y;
double x2;
double y2;

false_east = get_nc_var_att_double(grid_mapping_var, "false_east", false);
false_north = get_nc_var_att_double(grid_mapping_var, "false_north", false);
Expand All @@ -2469,8 +2469,11 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
if(!is_spherical_earch) eccentricity = st_eccentricity_func(semi_major_axis, semi_minor_axis,
inverse_flattening);

x = x_values[0];
y = y_values[0];
// MET #3358 Check for negative offset
double x = x_values[0];
double y = (data.dy_km > 0 ? y_values[0] : y_values.back());
double lat;
double lon;
scale_factor = st_sf_func(proj_standard_parallel, eccentricity, is_north_hemisphere);
st_xy_to_latlon_func(x, y, lat, lon, scale_factor, semi_major_axis,
proj_vertical_lon, false_east, false_north,
Expand All @@ -2488,6 +2491,8 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
}
}

double x2;
double y2;
st_latlon_to_xy_func(lat, lon, x2, y2, scale_factor, proj_vertical_lon,
semi_major_axis, false_east, false_north,
eccentricity, is_north_hemisphere);
Expand All @@ -2512,7 +2517,8 @@ void NcCfFile::get_grid_mapping_polar_stereographic(const NcVar *grid_mapping_va
grid.set(data);
grid_ready = true;

//Note: do not set grid.set_swap_to_north()
// MET #3358 Support Polar Stereographic NetCDF data packed north to south
if (data.dy_km < 0) grid.set_swap_to_north(true);

if(mlog.verbosity_level() >= 10) {
double lat1;
Expand Down
3 changes: 2 additions & 1 deletion src/libcode/vx_grid/grid_base.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1027,7 +1027,8 @@ return;
////////////////////////////////////////////////////////////////////////

bool Grid::get_swap_to_north() const {
return swap_to_north && (info().ll != nullptr || info().rll != nullptr);
return swap_to_north &&
(info().ll != nullptr || info().rll != nullptr || info().st != nullptr);
}

////////////////////////////////////////////////////////////////////////
Expand Down
Loading