GHA/Docker improvements#3409
Merged
Merged
Conversation
…se for testing. Added logic to change the MET base image repo to append '-dev' if the tag name doesn't start with a number, assuming that the value has been overridden since the tags in the regular repos are always numeric
…ly run when running unit tests
georgemccabe
moved this from 🩺 Needs Triage
to 🏗 In progress
in METplus-13.0 Development
georgemccabe
marked this pull request as ready for review
July 2, 2026 21:38
JohnHalleyGotway
previously approved these changes
Jul 8, 2026
JohnHalleyGotway
left a comment
JohnHalleyGotway
left a comment
Collaborator
There was a problem hiding this comment.
I approve of these changes.
I reviewed them and they all make sense to me, and I particularly like being able to select the base image tag as a workflow dispatch option. Beyond noting that all of the tests for this PR ran successfully, I did not actually do any additional testing.
github-project-automation
Bot
moved this from 🔎 In review
to 🏁 Done
in METplus-13.0 Development
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were changed made to test the abandoned switch to using UBI9 for the METbaseimage (dtcenter/METbaseimage#74) but are useful to include.
Note: Additions to LDFLAGS paths were needed to find libs in RedHat UBI 9. They aren't necessarily needed here but they don't hurt anything. We can remove these changes if desired.
Expected Differences
Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review changes
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the MET test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Will this PR result in changes to existing METplus Use Cases? [No]
If yes, create a new Update Truth METplus issue to describe them.
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by 7/15/2026.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release