fix: support stock Sushy emulator without custom root.json

[fabiendupont]

Summary

Fixes compatibility with stock upstream sushy-tools (tested against stable 2.2.0 from PyPI). Follow-up to #115.

@s3rj1k reported two issues when running NiCO against vanilla Sushy master:

1. HTTP 404 Not Found at /redfish/v1/UpdateService/FirmwareInventory (comment)
2. Stuck in HOSTINITIALIZING/WAITINGFORLOCKDOWN regardless of admin-cli input (comment)

Investigation revealed a third issue: stock Sushy has no Vendor field in the service root, so vendor auto-detection fails entirely — libredfish falls back to the generic RedfishStandard client instead of the Sushy vendor implementation.

Root causes and fixes

1. Vendor auto-detection (service_root.rs)

Stock Sushy 2.2.0 has no Vendor or Oem fields in the service root JSON, but uses "Id": "RedvirtService" and "Name": "Redvirt Service". Added id and name fields to ServiceRoot and extended vendor_string() with a third fallback that detects "sushy" or "redvirt" in those fields.

Previously, without a custom root.json template that injects "Vendor": "Sushy", libredfish resolved the vendor as Unknown and used the generic standard client — none of the Sushy-specific stubs applied.

2. lockdown_status stuck in WAITINGFORLOCKDOWN (sushy.rs)

The Sushy vendor returned Ok(Status::Enabled) for lockdown_status, faking a successful lockdown. Callers then believed the machine was locked down and waited for a state transition that could never happen. Changed to return Err(RedfishError::NotSupported("lockdown_status")), matching the RedfishStandard default for unsupported operations.

3. FirmwareInventory 404 (sushy.rs)

Stock Sushy 2.2.0 advertises FirmwareInventory in the UpdateService JSON body but doesn't implement the route handler (added in unreleased dev builds). The standard get_software_inventories call hits a raw 404. Added an override that tries the standard path first and converts a 404 into NotSupported. When the route exists (e.g. Metal3 dev builds with the controller), it works normally.

Test plan

• Unit tests: 3 new tests for Sushy vendor detection (explicit field, Id fallback, Name fallback)
• Full test suite passes (144 tests, 0 failures)
• Live tested against stock sushy-tools 2.2.0 (PyPI) in a container — no custom root.json, no patches
• Live tested against Metal3 dev build (0.0.1.dev405) with custom root.json — no regressions

🤖 Generated with Claude Code

[copy-pr-bot]

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

[Copilot]

🟡 Changes recommended

The new 404-handling guard compares reqwest::StatusCode to an integer literal (404), which will not compile and must be fixed before merge.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR improves compatibility with upstream/stock sushy-tools by making libredfish’s Sushy vendor detection and a couple of vendor-specific behaviors work without requiring a custom root.json template.

Changes:

• Extend ServiceRoot parsing and vendor detection to fall back on Id/Name patterns when Vendor/Oem are missing (stock Sushy behavior).
• Make lockdown_status report NotSupported for Sushy, aligning with the standard client and avoiding stuck state transitions.
• Add Sushy override for get_software_inventories to convert a FirmwareInventory 404 into NotSupported.

File summaries

File	Description
src/sushy.rs	Adjust Sushy vendor behavior for unsupported lockdown status and handle missing FirmwareInventory route gracefully.
src/model/service_root.rs	Add Id/Name fields and extend vendor auto-detection logic + tests for stock Sushy roots.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.