[Hot Aisle]: Store full VM specs in provider_data #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the recently introduced `RawCatalogItem.provider_data` field to associate each catalog item with the full VM specs object. This allows us to drop the hardcoded specs from the dstack implementation,
1 task
Bihan
reviewed
Nov 9, 2025
| import os | ||
| from typing import Optional | ||
| from typing import Optional, TypedDict, cast | ||
|
|
Collaborator
There was a problem hiding this comment.
I think TypedDict should come from typing_extensions. Other providers: nebius, gcp, runpod, oci using typing_extensions.
Collaborator
Author
There was a problem hiding this comment.
I'd say importing from the standard library is preferred, since it could let us drop the typing-extensions dependency in the future. In dstack, all TypedDict imports come from the standard library. Both options are equivalent, though
Bihan
approved these changes
Nov 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the recently introduced
RawCatalogItem.provider_datafield to associateeach catalog item with the full VM specs object.
This allows us to drop the hardcoded specs from
the dstack implementation.
See also dstackai/dstack#3239