Events emission framework and API #3325
Conversation
- Add the framework for event emission - Add the events API - Add a few sample events about project / user / fleet / instance / run / job creation.
| .order_by(*order_by) | ||
| .limit(limit) | ||
| .options( | ||
| joinedload(EventModel.targets), |
There was a problem hiding this comment.
IIUC, targets can potentially be from different projects. The access filter checks that an event has at least one target in the user's project but the response includes all the targets. Thus, event responses can leak targets from projects that users don't have access to.
There was a problem hiding this comment.
This may be expected in some cases.
Example: job assigned to instance, where the job and the instance are in different projects (will be possible once we allow sharing instances between projects, which is on the Q4 roadmap).
- Users in the job's project may need to know what instance it is assigned to.
- Users in the instance's project may need to know what jobs are assigned to it.
When this is not expected, it may be possible to split the event into several events with different targets. I don't think we'll have such cases anytime soon, but I described this behavior in the events.emit docstring.
- DB query and schema optimizations - Event logging - `DSTACK_FF_EVENTS` feature flag - More input validation - More unit tests - Various docs
Hidden behind the
DSTACK_FF_EVENTSfeature flag.Part of #3290
Next steps: