Sync DSS C-API (v0.12.1 main) header, update deps #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #84 +/- ##
===========================================
- Coverage 71.23% 59.02% -12.22%
===========================================
Files 44 55 +11
Lines 5813 7046 +1233
===========================================
+ Hits 4141 4159 +18
- Misses 1672 2887 +1215
Continue to review full report at Codecov.
|
|
Oh... there is much more missing than I expected. The bulk are API extensions/extras (CNData, LineGeometries, LineSpacings, Reactors, TSData, WireData), but there are a couple from the official too. I'll try to automate most of these some other day.
|
- Changes in utils.jl mostly to clean-up repeated code. We could refactor or regenerate most of the trivial code someday. - Fix error checking in CktElement.Variablei and CktElement.Variable - A few tests updated/corrected to reflect the changes
|
I'll try to add some tests, but if I don't have time by tomorrow, it's a good idea to release this since there are a couple of fixes. |
Hopefully handles part of #77
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CktElement.VariableiFuses_ResetargsCloses #83
Handles part of #78, but the official API is too limited and #82 will be required to actually access everything easily. Should handle part of #77.