Fix I/O error due to HTTP 416 when downloading empty files #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Today I started getting I/O errors when trying to read from or write to empty files using GDriveFS.
After some debugging I found out that it's getting HTTP 416 status (Request range not satisfiable) from the Google Drive servers when trying to download a file. I'm not sure if something has changed on the Google side, or why it worked before, but I think it does make sense to reply with 416 if the server can't return even a single byte from the requested range.
So I made this fix to treat 416 status as an empty file.