Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Fluid Selection #351

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Kalitsune
Copy link

I've noticed some usability challenges within the current launcher interface, including numerous small buttons and unnecessary steps for common actions. In an effort to enhance user experience, I've proposed several optimizations.

In the linked video below, you can observe the adjustments I've made:

Current launcher experience:

2024-05-12.17-38-29.mp4

Launcher experience with the changes implemented in this pull request:

2024-05-12.17-39-43.mp4

Any feedback or suggestions for further refinement is welcomed.

Removed the select and cancel buttons and made the buttons directly select the server
Edited the account selection menu so that it can be oppened in "popup" mode, allowing similar behavior to the fluid server selection without disturbing the account selection already in place in case of an account validation failure. This new popup menu also adds a "manage accounts" button to open the settings in the same way the old account selection menu did
@Ulysse2211
Copy link

I love the changes and love to see them added in the launcher. Thanks for making this !

@IkyMax
Copy link

IkyMax commented May 21, 2024

I love this! however, there is some strange error when pressing "esc" key, it throws a lore ipsum and blocks the launcher lmao

@Kalitsune
Copy link
Author

Hello! Thank you! I'll check that asap

By the way, the Lorem Ipsum is the default text shown in the overlay component, you're supposed to set its text before showing it. However since this part of the overlay is not supposed to open, this text is never set.

@Kalitsune
Copy link
Author

Yup I can confirm that this issue can indeed be encountered when closing the account selection menu with [esc], I will start working on fixing it now.

@Kalitsune
Copy link
Author

Done! The esc key now work properly on both the server and the account selection!

@Codixer
Copy link

Codixer commented Jun 18, 2024

+1 - Def need this 👁️👁️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants