Update plugin to support mypy 1.16.0 #2149
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is strange. I haven't seen these issues on my side. 🤔 |
sobolevn
reviewed
Jun 2, 2025
|
Oh? I didn't notice. I think I might have just ran |
|
yes, please :) |
|
Rebased against master and pinned version |
|
@sobolevn @Jazzinghen are there any plans to continue work on this PR? |
|
@svorcan-rho today [email protected] was released :) |
I was waiting for approval after my last commit. Was there something missing? |
|
the CI is still red, I would be happy to approve it after it is green :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have made things!
Checklist
CHANGELOG.mdRelated issues
Closes #2148
I have not updated the readme as there is no strict reference to the supported mypy version, and it looks like the changelog contains release info, so I didn't touch that one either.
All the checks passed, even though I had to add an ignore flag in a function that was using some strange trait-based property access.
I used a solution very similar to the one used in typeddjango/django-stubs#2670 but I get the version info using
importlibinstead of the string in the module.