Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(DataProducer): Fix missing cacheability bubble up on entity translations data producer #1353

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mxr576
Copy link
Contributor

@mxr576 mxr576 commented Aug 31, 2023

No description provided.

@mxr576
Copy link
Contributor Author

mxr576 commented Aug 31, 2023

The failure in tests/src/Kernel/DataProducer/Routing/RouteEntityTest.php should be unrelated... right?

Update: Yes, I see the same on #1346

@klausi
Copy link
Contributor

klausi commented Aug 31, 2023

Thanks - looking into the PHStan fails in #1354

@klausi
Copy link
Contributor

klausi commented Aug 31, 2023

That is resolved, can you merge the 8.x-4.x branch and try again here?

@klausi klausi merged commit bb2f0c0 into drupal-graphql:8.x-4.x Sep 4, 2023
6 checks passed
@klausi
Copy link
Contributor

klausi commented Sep 4, 2023

Thanks a lot!

klausi pushed a commit to klausi/graphql that referenced this pull request Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants