Fix error in payload generated by ImportmapGenerator

importmap/generator.py

@@ -36,7 +36,7 @@ def generate(self):
         response = requests.post(
             "https://api.jspm.io/generate",
             json={
-                "install": [self.targets],
+                "install": self.targets,
                 "env": self.get_env(),
                 "provider": self.provider,
             },

pyproject.toml

@@ -36,6 +36,7 @@ Django = "^4.0.0"
 ipdb = "^0.13.9"
 isort = "^5.10.1"
 jinja2 = "^3.1.2"
+pytest = "^8.3.3"
 
 [build-system]
 requires = ["poetry-core>=1.0.0"]

scripts/test

@@ -1,3 +1,5 @@
 #!/bin/sh -e
+.venv/bin/poetry run pytest
+
 cd test_project
 ../.venv/bin/python manage.py test "$@"

tests/test_importmap_generator.py

@@ -0,0 +1,58 @@
+import pytest
+from unittest.mock import patch, Mock
+import requests
+
+from importmap.generator import ImportmapGenerator, ImportmapGeneratorError
+
+def test_generate_success():
+    generator = ImportmapGenerator(targets=['react@17', 'react-dom@17'])
+
+    mock_response = Mock()
+    mock_response.json.return_value = {
+        'map': {
+            'imports': {
+                "react": "https://ga.jspm.io/npm:[email protected]/index.js",
+                "react-dom": "https://ga.jspm.io/npm:[email protected]/index.js"
+            }
+        }
+    }
+    mock_response.raise_for_status = Mock()
+    mock_response.status_code = 200
+
+    with patch('requests.post', return_value=mock_response) as mock_post:
+        result = generator.generate()
+        mock_post.assert_called_with(
+            "https://api.jspm.io/generate",
+            json={
+                "install": ['react@17', 'react-dom@17'],
+                "env": ['browser', 'module'],
+                "provider": 'jspm',
+            },
+        )
+        assert result == mock_response.json.return_value['map']
+
+def test_generate_error_in_response():
+    generator = ImportmapGenerator(targets=['react@17', 'react-dom@17'])
+
+    mock_response = Mock()
+    mock_response.json.return_value = {'error': 'Package not found'}
+    mock_response.raise_for_status = Mock()
+    mock_response.status_code = 200
+
+    with patch('requests.post', return_value=mock_response):
+        with pytest.raises(ImportmapGeneratorError) as exc_info:
+            generator.generate()
+        assert 'Package not found' in str(exc_info.value)
+
+def test_generate_http_error():
+    generator = ImportmapGenerator(targets=['react@17', 'react-dom@17'])
+
+    mock_response = Mock()
+    mock_response.json.return_value = {}
+    mock_response.raise_for_status.side_effect = requests.HTTPError('HTTP Error')
+    mock_response.status_code = 500
+
+    with patch('requests.post', return_value=mock_response):
+        with pytest.raises(requests.HTTPError) as exc_info:
+            generator.generate()
+        assert 'HTTP Error' in str(exc_info.value)