Skip to content

Make start/stop not race if called in quick succession #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Make start/stop not race if called in quick succession #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1adaf1e
Make start/stop safe for concurrent access
Jan 12, 2023
ab020f6
Remove mutex
Jan 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions perf_events.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,8 @@ type PerfEvents struct {
stopChannel chan struct{}
wg sync.WaitGroup

started bool

handlers []*perfEventHandler
}

Expand Down Expand Up @@ -135,6 +137,10 @@ func (pe *PerfEvents) StartForAllProcessesAndCPUs(bufferSize int) (<-chan []byte

// Stop stops event polling loop
func (pe *PerfEvents) Stop() {
if !pe.started {
return
}

// Stop poller firstly
pe.poller.Stop()
// Stop poll loop
Expand All @@ -154,10 +160,6 @@ func (pe *PerfEvents) startLoop() {
pe.updatesChannel = make(chan []byte)
pe.wg.Add(1)

go pe.loop()
}

func (pe *PerfEvents) loop() {
// Setup poller to poll all handlers (one handler per CPU)
pe.poller = newPerfEventPoller()
for _, handler := range pe.handlers {
Expand All @@ -166,6 +168,11 @@ func (pe *PerfEvents) loop() {

// Start poller
pollerCh := pe.poller.Start(pe.PollTimeoutMs)
pe.started = true
go pe.loop(pollerCh)
}

func (pe *PerfEvents) loop(pollerCh <-chan *perfEventHandler) {
defer func() {
pe.wg.Done()
}()
Expand Down