New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be a TLS enabled LoadBalancer #41

Open

gaima8 wants to merge 2 commits into drone:master from gaima8:loadbalancer

gaima8 commented Apr 1, 2021

We're using drone as a LoadBalancer service with TLS enabled via the certs extraVolume.
There are two problems with this.

There is only one ports to be open via the service, and is hardcoded to be HTTP. The servicePorts {} map makes ports totally configurable.
The liveness probe is hardcoded to talk HTTP to the port HTTP, but with TLS enabled drone responds with a HTTP 307 to plan HTTP requests, causing the liveness probe to fail. I'm using the existence of a certs volume to decide if TLS is enabled, and if so do HTTPS liveness probes.


          Be a TLS enabled LoadBalancer

50d5ec9

copart-jafloyd reviewed

View reviewed changes

charts/drone/templates/_helpers.tpl Outdated Show resolved Hide resolved


          Update charts/drone/templates/_helpers.tpl

1ca40bf

Co-authored-by: Jacob Floyd <[email protected]>

Contributor

jimsheldon commented Oct 21, 2022

Sorry for the delay here.

I think this would be a nice feature to add. If you can resolve the conflicts, I will review. Thanks!

jimsheldon added the enhancement label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels