Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the ability to configure agent logging #83

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mach6
Copy link

@mach6 mach6 commented Jan 29, 2021

Adds the ability to specify the logging driver and
options for the runner (agent), gc, and watchtower
containers.

Example config;

DRONE_AGENT_LOGGING_DRIVER=json-file
DRONE_AGENT_LOGGING_OPTIONS=max-size:100m,max-file:5

ref: https://docs.docker.com/config/containers/logging/configure/#supported-logging-drivers

engine/install.go Outdated Show resolved Hide resolved
@mach6 mach6 force-pushed the mach6_docker_logging_config branch from 6313324 to 8057c51 Compare January 29, 2021 01:17
@mach6
Copy link
Author

mach6 commented Feb 4, 2021

@bradrydzewski @tboerger Any feedback on this one? Cheers.

@tboerger
Copy link
Contributor

tboerger commented Feb 9, 2021

Why don't you just define the logging driver on Docker daemon level? IMHO it doesn't make sense to define that per container.

@mach6
Copy link
Author

mach6 commented Feb 10, 2021

Why don't you just define the logging driver on Docker daemon level? IMHO it doesn't make sense to define that per container.

While one can certainly do this; the intent with the per container config options is to enable finer configuration. for example; If one does not want the drone-gc or watchtower logging behavior to be the same as the agent. Maybe one wants the agent logs to leverage the gcplogs driver and drone-gc to leverage json-file, for example.

Also, setting the behavior at the daemon level impacts the logging behavior of the containers which support pipeline steps.

@mach6 mach6 closed this Feb 10, 2021
@mach6 mach6 reopened this Feb 10, 2021
@mach6 mach6 force-pushed the mach6_docker_logging_config branch from 8057c51 to fa3dcac Compare April 27, 2021 01:16
@mach6
Copy link
Author

mach6 commented Jun 14, 2021

@tboerger @bradrydzewski any additional thoughts on this one?

@mach6 mach6 force-pushed the mach6_docker_logging_config branch 2 times, most recently from 2498c1a to d523688 Compare July 21, 2021 01:25
@mach6 mach6 force-pushed the mach6_docker_logging_config branch from d523688 to 6ec1a6f Compare September 9, 2021 19:39
@mach6 mach6 force-pushed the mach6_docker_logging_config branch from 6ec1a6f to 0ade53b Compare April 19, 2022 23:47
Adds the ability to specify the logging driver and
options for the runner (agent), gc, and watchtower
containers.
@mach6 mach6 force-pushed the mach6_docker_logging_config branch from 0ade53b to 1afc5e2 Compare April 19, 2022 23:59
@mach6
Copy link
Author

mach6 commented Apr 20, 2022

PR re-based against v1.8.1 and force-pushed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants