Add driver for Brightbox Cloud #118
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @andatche Thank you for submitting this pull request. We'd be more than happy to get this merged. Would it be possible to add some unit tests, please? As well as some screenshots of it working such as the console logs? Obv making sure there's no sensitive info in it. Cheers, |
|
That's great, thank you! I'll go ahead and add some unit tests and screenshots/casts of it in action, as requested. I'll also make a start on adding some configuration documentation to the autoscaler-docs. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a driver implementing initial support for Brightbox Cloud.
The minimum required configuration is an API Client and Secret (https://www.brightbox.com/docs/reference/api-clients/) and a Server Group with a suitable Firewall Policy (https://www.brightbox.com/docs/reference/firewall/) which permits access to docker (TCP/2376) from your Drone instance.
DRONE_BRIGHTBOX_CLIENT_ID=cli-xxxxxDRONE_BRIGHTBOX_CLIENT_SECRET=<clientsecret>DRONE_BRIGHTBOX_SERVER_GROUPS=grp-xxxxxI'd be grateful for any feedback. I'd like to improve a few bits further if there's any interest in merging this: